Add unpack_input decorator to ViT model #16102
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
That's a good point. Actually, I think this will be true for all models after this change. Do you mind if I add it to my backlog, to confirm after this sprint? If we were to change this, I would have to bring in other Hugging Face members in (changing the signature of a public method is sensitive). |
|
STOP EMAILING ME!!!!!!!!!!!!!!!!!!!!!!
…Sent from my iPhone
On Mar 12, 2022, at 9:20 AM, Joao Gante ***@***.***> wrote:
@gante approved this pull request.
Fantastic, thank you so much for the contribution 👍
Can you confirm that you've run RUN_SLOW=1 py.test -vv tests/[model_name]/test_modeling_tf_[model_name].py? Will merge after your confirmation :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
|
|
Hi @debtriche 👋 GitHub doesn't send random emails, if you are receiving unwanted emails please check your subscription and emailing settings :) |
Yes, i run, but two test are skipped, all others pass |
What does this PR do?
I added the unpack_input decorator for the ViT model as describe in #16051
@gante
Maybe can also delete the
**kwargsfromcallparameters? (tests seems unaffected)